Closed cansavvy closed 3 years ago
Repeating this over here:
This is working as far as I can tell, but the one thing that's odd/not working really is the corner part in the videos are gone?
They aren't gone... it shows up after pressing play... but idk how to convey that more concisely/ assumed people when they saw the word video would press play. They can actually press twice on the right corner (on nothing) and it will expand- you don't have to click the center to play.
The text appears to be centered but not the video... let me check how I did that...
Ok here is an example of mine:
{type: video, poster: 'http://img.youtube.com/vi/VOCYL-FNbr0/mqdefault.jpg',height: "400px", width: "100%", align: "middle"} Click lower right corner of video to expand
I noticed that the comma is missing before align:"middle:" on the code so maybe that is why? Also I only tested with type:video, poster: at the beginning. Idk but maybe that makes a difference.
Yeah there's some commas we need I'm pretty sure. I'm adding them back and also adding a new check.
This is working as far as I can tell, but the one thing that's odd/not working really is the corner part in the videos are gone?
This is what the tags for the above look like (also note that "middle" doesn't work -- only "center").
Originally posted by @cansavvy in https://github.com/jhudsl/leanbuild/issues/14#issuecomment-906842702