search

jhudsl / ottrpal

Tools for converting OTTR courses into Leanpub or Coursera courses :otter:
https://jhudatascience.org/ottrpal/
GNU General Public License v3.0
3 stars 1 forks source link

Add commas and gha check #20

Closed cansavvy closed 3 years ago

cansavvy commented 3 years ago

This should fix this problem: https://github.com/jhudsl/leanbuild/pull/14#issuecomment-907156993

If all goes well, this should close #13 and close #17

There were some commas missing in the build_images() function and I'm adding a new check which checks out the files from https://github.com/jhudsl/DaSL_Course_Template_Leanpub and runs the latest leanbuild changes there.

cansavvy commented 3 years ago

This is working how it should, the only thing that isn't working is that the docker image probably needs a thing updated: https://github.com/jhudsl/DaSL_Course_Template_Bookdown/issues/163

I will check that that is the issue and rerun this later. I think its otherwise ready to go though.

cansavvy commented 3 years ago

The jhudsl/DaSL_Course_Template_Bookdown#163 error is resolved, now there's a new one that looks file path related: https://github.com/jhudsl/leanbuild/pull/20/checks?check_run_id=3451449028

cansavvy commented 3 years ago

It's working and we're all set! Close #13