search

jhudsl / ottrpal

Tools for converting OTTR courses into Leanpub or Coursera courses :otter:
https://jhudatascience.org/ottrpal/
GNU General Public License v3.0
3 stars 1 forks source link

Fix windows zip problem in vignette #50

Closed cansavvy closed 3 years ago

cansavvy commented 3 years ago

It appears rprojroot doesn't always work consistently on windows operating systems. I think that is the problem behind #49.

Edit: nope that wasn't the problem. Turns out Windows was having trouble unzipping the file to begin with and that had to do with its assumption that the example data zip file was a text file instead of a zip file like it is. So this is fixed by using mode = "wb" upon downloading with download.file().

cansavvy commented 3 years ago

Ugh. Windows is still failing. I thought I had it on that last one.

cansavvy commented 3 years ago

I've ran out of ideas on how to fix this right now. Will return to it later.

cansavvy commented 3 years ago

Going to retry this one more time now that the zip file doesn't have that weird folder (https://github.com/jhudsl/DaSL_Course_Template_Bookdown/issues/200)

cansavvy commented 3 years ago

Nope: 

cannot open file './docs/coursera/resources/images/home/rstudio/DaSL_Course_Template_Bookdown/docs/coursera/01-intro_files/figure-html/1YmwKdIy9BeQ3EShgZhvtb3MgR8P6iDX4DfFD65W_gdQ_gcc4fbee202_0_141.png': No such file or directory
cansavvy commented 3 years ago

But alternatively I may just get rid of that coursera folder because we don't really need it.

cansavvy commented 3 years ago

Abandoning this strategy for another solution: #56 This PR is no longer relevant.