search

jhudsl / ottrpal

Tools for converting OTTR courses into Leanpub or Coursera courses :otter:
https://jhudatascience.org/ottrpal/
GNU General Public License v3.0
3 stars 1 forks source link

Severing ties with didactr - Part II #51

Closed cansavvy closed 3 years ago

cansavvy commented 3 years ago

This is the second attempt at #46 as a part of the goals of #32

I'm trying to see if we can get rid of didactr as a dependency and I think its simpler than we think. I looks like the main function that uses didactr isn't tied to anything else and isn't something we need? I just simply deleted the gs_to_drive_png related functions but made sure to keep the simply download png related functions.

I think if someone really needs the gs_to_drive_png functionality they can just go to didactr then. I don't think we need it in this package but I may be proven wrong.

cansavvy commented 3 years ago

Okay, this has succeeded. I'm going to merge it but if later this turns out to be a bad idea we can always revert these changes. 😨