jhudsl / ottrpal

Tools for converting OTTR courses into Leanpub or Coursera courses :otter:
https://jhudatascience.org/ottrpal/
GNU General Public License v3.0
3 stars 1 forks source link

Citeproc Strikes Back: Add warning and fix syntax #57

Closed cansavvy closed 3 years ago

cansavvy commented 3 years ago

Background issues to this ongoing problem: #7 and #48

Basically you need a certain version of pandoc (greater than 2.11) to render citations properly. If you don't have greater than that before leanbuild would just break. Now I just have it give you a warning that the citations won't build but it will continue.

Also had my logic had the syntax incorrect so I had to fix that so that the question would be asked properly. Didn't realize in this particular instance numbers aren't actually treated like numbers in R. rmarkdown::pandoc_version() gives you a numeric_version which is different than a number. TIL.

cansavvy commented 3 years ago

The windows error is not related to the changes in this PR. It's still related to the problem that I will try to address in #50