search

jhudsl / ottrpal

Tools for converting OTTR courses into Leanpub or Coursera courses :otter:
https://jhudatascience.org/ottrpal/
GNU General Public License v3.0
3 stars 1 forks source link

Make so quiz_dir can be NULL #83

Closed cansavvy closed 3 years ago

cansavvy commented 3 years ago

Purpose/implementation Section

What changes are being implemented in this Pull Request?

This is still related to #82 The checks were failing and I was adding a fix for that.

cansavvy commented 3 years ago

No. I misunderstood the fail. I was right the first time, but it's the vignette that is failing because in the vignette I didn't put the quizzes in a folder.

cansavvy commented 3 years ago

No. I misunderstood the fail. I was right the first time, but it's the vignette that is failing because in the vignette I didn't put the quizzes in a folder.

At least not the first time I run bookdown_to_leanpub()

carriewright11 commented 3 years ago

is the fail due to https://github.com/jhudsl/leanbuild/blob/master/R/example_data.R

carriewright11 commented 3 years ago

No. I misunderstood the fail. I was right the first time, but it's the vignette that is failing because in the vignette I didn't put the quizzes in a folder.

At least not the first time I run bookdown_to_leanpub()

ah just saw this.. yeah makes sense

cansavvy commented 3 years ago

It didn't have to do with copy_quizzes() at all, it was because if you use quiz_dir = NULL then the making book.txt part of the function fails, but now I put in some logic around that.

cansavvy commented 3 years ago

Great! I think this is all set!

carriewright11 commented 3 years ago

Great! I think this is all set!

YAY looks good!