search

jhudsl / ottrpal

Tools for converting OTTR courses into Leanpub or Coursera courses :otter:
https://jhudatascience.org/ottrpal/
GNU General Public License v3.0
3 stars 1 forks source link

Adding embed functionality for Leanpub conversion #90

Closed cansavvy closed 2 years ago

cansavvy commented 2 years ago

Purpose/implementation Section

What changes are being implemented in this Pull Request?

This is working to address: https://github.com/jhudsl/OTTR_Template/issues/381

Adding functions here that will create markdowns with iframes for Leanpub.

What was your approach?

The way this works is that you can give a TSV that has chapter urls and specifies image paths for each. You can supply a default image for all chapters, or if you don't supply any images there's a default OTTR image that will be used for you.

The main function is (at it's minimum arguments specified is: ottr::bookdown_to_embed_leanpub(base_url)

The one required item is that you must specify the base_url.

These functions will be called by Github actions in OTTR_Template and OTTR_Quizzes.

What GitHub issue does your pull request address?

https://github.com/jhudsl/OTTR_Template/issues/381

cansavvy commented 2 years ago

Windows is failing #73 but everything else is working. Going to merge.