search

jhugman / uniffi-bindgen-react-native

A uniffi bindings generator for calling Rust from react-native
https://jhugman.github.io/uniffi-bindgen-react-native/
Other
50 stars 5 forks source link

Fix documentation publishing #110

Closed ianthetechie closed 1 month ago

ianthetechie commented 1 month ago

Super cool project! I get a bunch of React Native requests for a library I work on and am looking forward to giving this a try!

I noticed when looking for docs that you've got GitHub pages set up, but it's not easy to find, since it's under an html subdirectory right now: https://jhugman.github.io/uniffi-bindgen-react-native/html/. I figured this out after downloading the CI artifact.

I think this tweak to the workflow will make the docs more accessible. Might also want to link it in the repo metadata on GitHub so there's a link right there on the right side, but I can't open a PR for that ;)

ianthetechie commented 1 month ago

Let's see; this stuff I find a bit confusing.

You and me both ;)

I'll merge and then have a look at what happens.

Devops these days: "I literally have no way of testing this locally, there is no option but push and see what breaks" 😂

ianthetechie commented 1 month ago

Looks like it worked :) https://jhugman.github.io/uniffi-bindgen-react-native/

jhugman commented 1 month ago

Devops these days: "I literally have no way of testing this locally, there is no option but push and see what breaks" 😂

Haha.

Looks like it worked :)

:fistpumpbaby:

Thank you so much!