Closed Johennes closed 1 month ago
I love this test!
I'm aware that it might not run on CI, but do you think it would be worth putting it in the scripts directory?
I love this test!
I'm aware that it might not run on CI, but do you think it would be worth putting it in the scripts directory?
I wasn't sure how soon your testing project would land, so I didn't add it to the PR in an attempt not to interfere with that. If it's not around the corner, I can definitely add the script to the folder. I can also add it to the integration tests in the GitHub workflow. I believe GitHub acts upon shell exit codes, so it might even run as is.
Unfortunately dealing with tags and branches in shallow clones turned out more involved than I thought. This change uses
git ls-remote
to determine the SHA of a branch or tag without fetching the entire history.In case it helps, I've used the following (dumb) script to test my changes:
Fixes: #118