search

jhugman / uniffi-bindgen-react-native

A uniffi bindings generator for calling Rust from react-native
https://jhugman.github.io/uniffi-bindgen-react-native/
Other
50 stars 5 forks source link

Set up CI for bob / rn compatibility matrix #163

Open Johennes opened 1 week ago

jhugman commented 1 week ago

Quick drive by, I know it's in draft, just a quick note to say:

This is stunning. It's going to be so helpful. Thank you.

Johennes commented 6 days ago

I think this is in a state where it can be reviewed now.

I thought a bit about adding further dimensions to the test matrix such as org-scoped vs. non-org-scoped package name and standard vs. custom codegen output paths. However, these would make the number of combinations and CI jobs soar.

Instead I just used bob version, RN version and platform for the test matrix dimensions and always use an org-scoped package name and custom codegen output paths. The thinking there is that if e.g. the job succeeds with custom codegen paths, it is likely to also succeed with the default ones whereas the opposite is not true.

The jobs currently all fail because of #161.

I would suggest to also run the workflow on PRs (as it is configured right now) but to not make it block the PR. This can be achieved by tweaking the required status checks in the repository settings.

Johennes commented 2 days ago

I will let you be the arbiter of ordering you land it in. Getting it all in order with https://github.com/jhugman/uniffi-bindgen-react-native/issues/161 may need the build to break for a little bit, but I'm okay with that.

Thanks. I guess since this is fairly well isolated, I'll let it sit for a while in hopes that I can figure out #165 and then merge both together.