jhugman / uniffi-bindgen-react-native

A uniffi bindings generator for calling Rust from react-native
Other
0 stars 0 forks source link

Simplify React name trimming function. #44

Open wesc opened 1 month ago

wesc commented 1 month ago

This simplifies the way in which we create a trimmed react name, which has downstream implications in a few places. For example, this function is used in generating the Native___ names, spec names, and namespace. Previously, if you named your package RNFoo vs Foo then you would get FooSpec in both cases, as well as placement in the foo namespace. This is specialized knowledge a user of the ubrn would need to know. Whereas now, RNFoo results in RnFooSpec and rnfoo, and Foo results in FooSpec and foo.

It's possible I've misunderstood what the point of this was.. just I was having difficulty understanding in what cases I could drop RN, and in what cases Native got prefixed. I'm open to doing something different here, I just want to minimize the surprise from the user's perspective.