jhump / protoreflect

Reflection (Rich Descriptors) for Go Protocol Buffers
Apache License 2.0
1.35k stars 172 forks source link

protoparse: fixes to issues reported in v1.15.0 #554

Closed jhump closed 1 year ago

jhump commented 1 year ago

This addresses a data race, caused by the fact that v1.15.0, under the hood, now uses protocompile, and protocompile as of v0.3.0 is possibly more susceptible to this issue. See https://github.com/bufbuild/protocompile/issues/102.

It also addresses a regression -- an unintended change in behavior due to the use of protocompile regarding how custom options are represented in the returned descriptors. See #553.

Part of this fix is to upgrade to the latest version protocompile, which also brings over a version of descriptor.proto from protoc v22, which meant some updates to test data.