jhump / protoreflect

Reflection (Rich Descriptors) for Go Protocol Buffers
Apache License 2.0
1.35k stars 172 forks source link

SIGSEGV: panic: runtime error: invalid memory address or nil pointer dereference #574

Closed mprimeaux closed 1 year ago

mprimeaux commented 1 year ago

This PR addresses issue #572 by adding a nil check when the parser is recursing to infer import paths.

mprimeaux commented 1 year ago

Closing since @jhump is working on a more holistic fix to address the nil pointer dereference.

jhump commented 1 year ago

See #575 for the alternate fix. That PR is much more involved since it also includes some other fixes/improvements in order to get new tests of the InferImportPaths functionality to pass.