search

jhump / protoreflect

Reflection (Rich Descriptors) for Go Protocol Buffers
Apache License 2.0
1.35k stars 172 forks source link

Tests broken with google.golang.org/protobuf v1.33.0 #597

Closed psydvl closed 8 months ago

psydvl commented 8 months ago

In https://github.com/jhump/protoreflect/blob/7195054027de0de09df8b00cfa8ecc5775201c36/desc/builder/builder_test.go#L1656-L1677 TestInvalid/group_in_proto3 TestInvalid/default_value_in_proto3

$ go test ./desc/builder/
--- FAIL: TestInvalid (0.00s)
    --- FAIL: TestInvalid/group_in_proto3 (0.00s)
        builder_test.go:1733: unexpected error: want "invalid group: invalid under proto2 semantics", got "proto: message field \"Foo.bar\" is an invalid group: invalid under proto3 semantics"
    --- FAIL: TestInvalid/default_value_in_proto3 (0.00s)
        builder_test.go:1733: unexpected error: want "invalid default: cannot be specified under proto3 semantics", got "proto: message field \"Foo.foo\" has invalid default: cannot be specified with implicit field presence"
FAIL
FAIL    github.com/jhump/protoreflect/desc/builder  0.074s
FAIL

NB: google.golang.org/protobuf@v1.33.0 resolve CVE-2024-24786 https://groups.google.com/g/golang-announce/c/ArQ6CDgtEjY https://github.com/protocolbuffers/protobuf-go/releases/tag/v1.33.0