update format with rubocop --safe-auto-correct

jhund / filterrific

Filterrific is a Rails Engine plugin that makes it easy to filter, search, and sort your ActiveRecord lists.

http://filterrific.clearcove.ca

MIT License

910 stars 124 forks source link

update format with rubocop --safe-auto-correct #174

Closed fniscak closed 5 years ago

fniscak commented 5 years ago

I hope that this time the update is correct.

jhund commented 5 years ago

@fniscak looks great. There is one more thing I'd like you to change: The in-page links on the scope patterns page need some updating. Until now the TOC at the top of the page referred to tags I inserted manually. Now the hrefs in the TOC are changed to go to the auto-generated ids on the headings (hyphens vs. underscores). This is fine, however now we don't need the manual tags any more. Could you please remove them?

fniscak commented 5 years ago

links/anchors have been corrected - vscode plugin effects

jhund commented 5 years ago

@fniscak thank you for the PR!

fniscak commented 5 years ago

I felt that it needed to be done. It is just a first step.

On Mon, Jan 21, 2019 at 12:07 PM Jo Hund notifications@github.com wrote:

@fniscak https://github.com/fniscak thank you for the PR!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jhund/filterrific/pull/174#issuecomment-456186476, or mute the thread https://github.com/notifications/unsubscribe-auth/AOZjhAACSpVAeTGvFGAjUxrbv9PdSlvBks5vFh4UgaJpZM4aKEn5 .