jhund / filterrific

Filterrific is a Rails Engine plugin that makes it easy to filter, search, and sort your ActiveRecord lists.
http://filterrific.clearcove.ca
MIT License
910 stars 125 forks source link

Syntax error on gem 5.1.0 #176

Open michelboaventura opened 5 years ago

michelboaventura commented 5 years ago

Hi,

The file lib/filterrific/engine_api.rb inside gem version 5.1.0 has a syntax error. The line beginning with TODO should've been commented.

# -*- coding: utf-8 -*-

require 'filterrific/param_set'

require 'filterrific/action_controller_extension'
require 'filterrific/active_record_extension'

module Filterrific
  class EngineApi < ::Rails::Engine

TODO: Since this is API only, I don't think we need an engine!
    # It's an engine so that we can add javascript and image assets
    # to the asset pipeline.

    isolate_namespace Filterrific

    ActiveSupport.on_load :action_controller do
      include Filterrific::ActionControllerExtension
    end

    ActiveSupport.on_load :active_record do
      extend Filterrific::ActiveRecordExtension
    end

  end
end
Hamdan85 commented 5 years ago

I'm also having this issue

Hamdan85 commented 5 years ago

in fact, the code in this repository is already OK. Probably @jhund didnt updated rubygems