search

jhund / filterrific

Filterrific is a Rails Engine plugin that makes it easy to filter, search, and sort your ActiveRecord lists.
http://filterrific.clearcove.ca
MIT License
910 stars 124 forks source link

5.2 broken for array filters on RubyGems, but not GitHub #186

Closed qapn closed 5 years ago

qapn commented 5 years ago

Hello! I've come across a minor issue - the version of 5.2 released on RubyGems is not the same as the version of 5.2 on GitHub.

With the RubyGems version, array based filters do not work, but with the GitHub version, they do.

There's a small change on RubyGems to lib/filterrific/param_set.rb line 99 that I think is responsible for the issue.

RubyGems 5.2: fp[key] = fp[key].map { |e| e =~ integer_detector_regex ? e.to_i : e }.find_all { |e| }

GitHub 5.2: fp[key] = fp[key].map { |e| e =~ integer_detector_regex ? e.to_i : e }

I would offer a pull request, but everything is fine on GitHub.

PS, love your gem and all the work you've done on it, thanks heaps!

jhund commented 5 years ago

@qapn thanks for the report. What error do you get? Can you please provide me with a scenario to reproduce the issue?

jhund commented 5 years ago

This was caused by having some uncommitted code being pushed to rubygems. I just released 5.2.1 to address the issue.

qapn commented 5 years ago

@jhund thanks for the lightning fast fix!