search

jhund / filterrific

Filterrific is a Rails Engine plugin that makes it easy to filter, search, and sort your ActiveRecord lists.
http://filterrific.clearcove.ca
MIT License
910 stars 124 forks source link

Version 5.2.4 should be breaking change release #219

Open 0llirocks opened 1 year ago

0llirocks commented 1 year ago

I don't know if you are still using semantic versioning after you changed your versioning strategy to match supported rails version, but version 5.2.4 breaks existing code since you removed jQuery (which is a good thing).

The following line doesn't work anymore and must be changed

Old: //= require filterrific/filterrific-jquery

New: //= require filterrific/filterrific

From my point of view, this is a breaking change and should not be a patch release.

MisterGetman commented 1 year ago

Indeed! //= require filterrific/filterrific-jquery gave me an error:

ActionView::Template::Error (couldn't find file 'filterrific/filterrific-jquery' with type 'application/javascript'