jhund / filterrific

Filterrific is a Rails Engine plugin that makes it easy to filter, search, and sort your ActiveRecord lists.
http://filterrific.clearcove.ca
MIT License
910 stars 124 forks source link

Version 5.2.4 - JS breaks if no .filterrific_spinner available #220

Open 0llirocks opened 1 year ago

0llirocks commented 1 year ago

Version: 5.2.4

If your code has no .filterrific_spinner class, the javascript code breaks at https://github.com/jhund/filterrific/blob/master/app/assets/javascripts/filterrific/filterrific.js#L22 which results in no javascript functionality at all e.g. .filterrific-periodically-observed doesn't work anymore. Adding an empty div with .filterrific_spinner class fixes the issue.

Error message: caught TypeError: Cannot read properties of null (reading 'style') at Filterrific.submitFilterForm (filterrific.source.js:22:1) at check (filterrific.source.js:127:1)