search

jhunt / k8s-boshrelease

A BOSH Release for deploying Kubernetes clusters
MIT License
13 stars 9 forks source link

add delete node on drain #71

Closed obeyler closed 4 years ago

obeyler commented 4 years ago

Fix : https://github.com/jhunt/k8s-boshrelease/issues/70

add a kubectl delete node while drain usefull when number of node change

jhunt commented 4 years ago

Per the Contributing Guidelines for this repo:

When contributing to this repository, please first discuss the change you wish to make via issue, email, or any other method with the owners of this repository before making a change

I know I've been a little lax here and let this slide for the past few PRs, and for that I apologize.

However, I don't think this PR is the correct way to solve this problem. Let's discuss on the issue (#70) before another pull request is submitted.

obeyler commented 4 years ago

I had proposed this solution in the issue. As it was not a big job to do, I proposed this PR to be ready if the discussion goes the same way. I tested it and it works well but there may be a more elegant way to do it. We're not in the same time zone so I was allowing myself to make PR proposals to save time. I don't mind if the PR is not taken or thrown away.