Issue #1000 Resolution: Fetch news modal data for new users even though modal does not initially display

jhuopensource / semesterly

Your Semester Made Easier | Course Scheduling & Social Tools for Students

https://semester.ly

GNU General Public License v3.0

33 stars 56 forks source link

Issue #1000 Resolution: Fetch news modal data for new users even though modal does not initially display #1067

Closed spencerckhuang closed 8 months ago

spencerckhuang commented 8 months ago

Description

Resolving Issue #1000. Also added default values for news values if, after fetched, the news title/body are empty (this shouldn't happen but, if it does, the modal will now at least display something)

spencerckhuang commented 8 months ago

Trying to test on local dev environment but not able to fetch news information. Tested "https://jhu.sem.ly/notifications/news" GET request via Postman and am getting blank json data as well. Does that endpoint only work in production?

spencerckhuang commented 8 months ago

strange webdriver and invisibility assertion E2E test failures... :(