jhuopensource / semesterly

Your Semester Made Easier | Course Scheduling & Social Tools for Students
https://semester.ly
GNU General Public License v3.0
32 stars 56 forks source link

App allows you to delete only timetable remaining #1084

Open spencerckhuang opened 6 months ago

spencerckhuang commented 6 months ago

Contact Details

No response

Describe the Bug

If you only have one timetable and you try to delete it, the timetable is removed internally (i think?) but it is still displayed to user except with timetable dropdown arrow gone. Only way to resolve is to refresh -- when this happens, it resets as usual.

How can we reproduce the problem?

  1. Remove all current timetables except one
  2. Add some classes (to see that later, they still show even after "removing" the timetable)
  3. Using the timetable dropdown menu on the right sidebar, delete the current (only) timetable

Expected Behavior

App should probably not let you delete a timetable if it's the only one you have left, so one solution is just to bar this from happening with an alert modal or something (in this case, it would also be a good idea to implement some feature that allows you to automatically clear all courses in a timetable).

Otherwise, if it is still considered okay that you can delete the only timetable you have left, page should reflect that immediately without needing a manual refresh

OS Version

Windows

Which browsers are you seeing the problem on?

Chrome

Additional Information

No response

Code of Conduct