search

jhviggo / sep4-iot

1 stars 0 forks source link

Co2 sensor impl #12

Closed OZoneSQT closed 2 years ago

OZoneSQT commented 2 years ago

CO2 and Light sensor Impl. and Task handlers OK, "links"-folder renamed to "handlers" UML is updated

jhviggo commented 2 years ago

It's pretty confusing that half the file changes are from Florinas branch which you merged into your branch. We can't really merge your changes and half of her changes into master. Either you should wait for her changes to get into master and then rebase, or you should probably delete all the temperature and humidity changes that aren't related to your change 😄

jhviggo commented 2 years ago

Other than that I think you changes for the C02 looks good.

OZoneSQT commented 2 years ago

ok