search

jhvst / vertigo

Blog engine in Go (golang)
https://toldjuuso.github.io/vertigo
MIT License
264 stars 24 forks source link

commenting system or pure medium-style? #39

Closed ghost closed 9 years ago

ghost commented 9 years ago

As you can tell, medium doesn't have any type of commenting-system embedded but it would be simple to add in vertigo. It would only take a discus input field in the settings to implement a pretty decent commenting interface via disqus but do you think it's necessary?

jhvst commented 9 years ago

Jay's fork already has it. If you can fork the current master branch and add the feature to it, then sure, I'll accept the PR.

Then again, Disqus does not necessarily need a backend modifications, which I'd rather keep to bare minimum. Therefore, if you alternatively want to write a wiki page how to add Disqus's JS snippet onto the templates, I'd be happy as well.

e: In general, my goal was to keep JavaScript in bare minimum when it comes to the main application. Users may add JavaScript to the site if they want to, but I don't want to ship any unnecessary JS code.

jayrox commented 9 years ago

Yea, its not really required to be added to the core. I only added it because i think it was easier that way to maintain On May 20, 2015 6:32 AM, "Juuso Haavisto" notifications@github.com wrote:

Jay's fork https://github.com/jayrox/vertigo already has it. If you can fork the current master branch and add the feature to it, then sure, I'll accept the PR.

Then again, Disqus does not necessarily need a backend modifications, which I'd rather keep to bare minimum. Therefore, if you alternatively want to write a wiki page how to add Disqus's JS snippet onto the templates, I'd be happy as well.

— Reply to this email directly or view it on GitHub https://github.com/9uuso/vertigo/issues/39#issuecomment-103838362.