Tanh operation is missing from Character-level Convolutional Neural Network

jhyuklee / charnlm-pytorch

Re-Implementation: Character-Aware Neural Language Models

MIT License

3 stars 3 forks source link

Open hadi-gharibi opened 5 years ago

hadi-gharibi commented 5 years ago

Based on the formula number 5, I think you need to add Tanh after the conv layer in the char_conv_layer function. Untitled

jhyuklee commented 5 years ago

Thanks! I think I missed it.