search

ji-devs / draft-canvas

https://jewish-interactive.github.io/draft-canvas
MIT License
0 stars 0 forks source link

Remove "Close" button feature #18

Closed dakom closed 6 years ago

dakom commented 6 years ago

The responsibility of rendering vs. null should be on the containing app

dakom commented 6 years ago

I've changed the title here - instead of a callback, the "close" functionality should be controlled by the higher-order component (any cleanup DraftCanvas needs to do should be handled in lifecycle).

Similarly, the design and placement of the close button is the responsibility of the calling app, not DraftCanvas

jpuri commented 6 years ago

Ah, ok let me remove the close functionality.