search

ji-devs / draft-canvas

https://jewish-interactive.github.io/draft-canvas
MIT License
0 stars 0 forks source link

Re-mounting fails #19

Closed dakom closed 6 years ago

dakom commented 6 years ago

When embeded in a higher component and togged between mounted/un-mounted (e.g. rendering null, then <DraftCanvas />, then null, then <DraftCanvas /> again - it is no longer visible on the second mounting

jpuri commented 6 years ago

Hey @dakom : can you plz share the higher component code. That will help me identify the issue.

dakom commented 6 years ago

Sure - I'll do that a bit later today :)

Note that it's somewhat related to issues #18 and #20 since it's "issues of embedding elsewhere"

These - #18, #19, #20 should be the top-priority for the next milestone. Would you like me to indicate that somewhere besides this comment?

dakom commented 6 years ago

Hmm... when I re-create the same scenario here it works fine (temporarily pushed in the temp-remove branch)

I'll have to check into this deeper, will assign this issue to myself for now. Feel free to ignore it... #20 is the current highest priority. Thanks!

jpuri commented 6 years ago

This might be related to ref being called only once, though I am not sure.

dakom commented 6 years ago

Seems to be fixed now :)