ji-devs / ji-cloud

Other
11 stars 17 forks source link

Profile - editing the email should not be a simple edit #1350

Open corinnewo opened 3 years ago

corinnewo commented 3 years ago

Since editing the email is not so simple, connected with google sign in, etc, we need a button to EDIT the email. Then we need a flow for changing the email. eg - do we send a confirmation email to the old address or to the new address? Need to discuss.

GaliShapira commented 3 years ago

@corinnewo @dakom What do you think about this flow?

  1. User clicks on the Edit button on the profile page or unlock icon on the field.
  2. The user types the new email and confirm.
  3. He sees a message "Please check your mail, We just sent you an email. hyperlink "Send again". Click on the hyperlink sending another email. We can say Make sure the email address is correct.
  4. Email design: You asked to change your email on JIGZI. Click here to confirm this is the correct email.
  5. Page design: Your new email is successfully updated. Button "explore JIGZI site. (In the profile page the email is updated).

What should be the status of the email after the user changed it and before he verified? Option 1: The new email address with an alert icon that its not verified. (Then there is no email for this account?) Option 2: 2 and 3 are on a popup. so until the new email is confirm the older email is there. (I think this is a better option)

Hope its clear. If not, perhaps we make a short Zoom on Monday. I would like to be sure of the flow before I design.

dakom commented 3 years ago

Yes, I think this will work fine. Fwiw I agree that option 2 is the better way, and if they leave the page it's as though they never tried to change their email at all (i.e. we don't preserve the state of showing the popup if they refresh the page).

Not only is it technically easier, I think it's clearer for the user who might come into their profile a month later and forget that they tried to reset their email before.

corinnewo commented 3 years ago

I think it looks good. Just some small tweaks to the language:

  1. You asked to change your email on JIGZI. Click here to confirm that this is the correct email address.
  2. Your new email has been updated successfully. (Not sure why you need a button to explore the site, as they are on the profile page, and there is the menu along the top) I agree with Option 2. too!
GaliShapira commented 3 years ago

@corinnewo As for number 5, I thought that when confirm the email (it may not be in the next day...) we take them to a special with the notification and the button, maybe an illustration. Like the page after confirm the registration.

corinnewo commented 3 years ago

Oh - ok. Then it makes sense!

On Thu, 19 Aug 2021 at 17:17, GaliShapira @.***> wrote:

@corinnewo https://github.com/corinnewo As for number 5, I thought that when confirm the email (it may not be in the next day...) we take them to a special with the notification and the button, maybe an illustration. Like the page after confirm the registration.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ji-devs/ji-cloud/issues/1350#issuecomment-902002338, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD4JEOO5L44TGW2GN4HIXWDT5UN7ZANCNFSM5CIDTR3Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

--

•••

Corinne Ossendryver CPO

Jewish Interactive

mobile +27 (0)79 886 5326 web www.jewishinteractive.org

skype jewish.interactive fax 086 273 0351 (SA only) twitter @jewishinteract facebook www.facebook.com/JewishInteractive

GaliShapira commented 3 years ago

Hi @corinnewo @dakom @MendyBerger Pls see the updating email flow: https://zpl.io/awdBBqN https://zpl.io/aRwBBMn https://zpl.io/bzxll83 https://zpl.io/bAK99mx https://zpl.io/ag1oo81

MendyBerger commented 3 years ago

Blocked by #1550