Admin pages - the admin and student code interferes with content

[corinnewo]

Now that you have added in the admin and student code 'tabs', they interfere with the image admin area. On all other pages, they look great (on create, etc), but within admin, they really interfere - cant see the search field easily, etc.

Can you hide them from the menu bar if you are in the admin area? You would not need the student code link if you are in admin, and you are already in admin, so do not need the button to go to admin at this stage.

[chayaml]

Leaving this open - Admin and student code tabs were updated to not interfere with the search bar, but can we hide them in admin area?

[dakom]

I think this is related to https://github.com/ji-devs/ji-cloud/issues/1506

Perhaps @GaliShapira should create a Zeplin screen with all of our top-menu states, so that we have a single reference?

implementation note: once we have a single reference of explicit states, @MendyBerger can implement these variations by switching on an enum, so we can have something predictable like:

#[derive(Copy, Clone, Eq, PartialEq, Debug)]
enum HeaderNavMode {
  Regular,
  Admin,
  Kids
}

impl From<Route> for HeaderNavMode {
  fn from(route:Route) -> Self {
    match route {
      Route::Admin(_) => Self::Admin,
      Route::Kids(_) => Self::Kids,
      _ => Self::Regular,
    }
  }
}

[corinnewo]

The top panel with admin and code is good everywhere, except in the admin panel, where it is not needed, and should be hidden. I don't think we need to involve Gali with this.

On Fri, 3 Sept 2021 at 08:44, David Komer @.***> wrote:

I think this is related to #1506 https://github.com/ji-devs/ji-cloud/issues/1506

Perhaps @GaliShapira https://github.com/GaliShapira should create a Zeplin screen with all of our top-menu states, so that we have a single reference?

implementation note: once we have a single reference of explicit states, @MendyBerger https://github.com/MendyBerger can implement these variations by switching on an enum, so we can have something predictable like:

[derive(Copy, Clone, Eq, PartialEq, Debug)]

enum HeaderNavMode { Regular, Admin, Kids }

impl From for HeaderNavMode { fn from(route:Route) -> Self { match route { Route::Admin() => Self::Admin, Route::Kids() => Self::Kids, _ => Self::Regular, } } }

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ji-devs/ji-cloud/issues/1457#issuecomment-912298089, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD4JEOLDE5UVGUTFP65SCATUABVC7ANCNFSM5C25LEIQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--

•••

Corinne Ossendryver CPO

Jewish Interactive

mobile +27 (0)79 886 5326 web www.jewishinteractive.org

skype jewish.interactive fax 086 273 0351 (SA only) twitter @jewishinteract facebook www.facebook.com/JewishInteractive

https://www.charidy.com/kidsloveji/corinne

[dakom]

ok, no need to involve Gali - but even without the visual reference I think it's much better to model this as a self-contained component where all the changes are made in one place rather than ad-hoc changes from, technically, unrelated parts of the codebase.

@MendyBerger - in more detail, the way I'd propose handling this is that the header component should have its own internal dominator::routing::url() - that way it will just work properly wherever it happens to be used

[GaliShapira]

I think that once we are in the content manager pages we dont need to see the button that takes us there, so I suggest to remove it from these pages. I will check if this button bothers us in the search results and in the creator page and the rest of the pages, and I will update here on Thursday. (I assigned myself)