ji-devs / ji-cloud

Other
11 stars 17 forks source link

Create - Copy activity #2200

Closed ChaykeeMor closed 1 year ago

ChaykeeMor commented 2 years ago

Must have a way to paste activity. Currently, in activity kabob menus, advanced options we have 'copy to another JIG'.

Screen Shot 2022-01-07 at 13 13 05

Then the only way to paste is into a poster activity. NO WAY FOR USER TO FIGURE THAT OUT and they should be able to paste anywhere..

Screen Shot 2022-01-07 at 13 13 17

What is needed: So in the kabob of any module should take out 'copy to another JIG' and replace with options 'Copy activity' 'Copy design' 'Paste activity' and 'Paste design'. If possible technically, I'd have paste options hidden until you have copied something.

@MendyBerger how doable is this?

corinnewo commented 2 years ago

At the very least:

  1. fix up the paste so that you can paste into a JIG after any module. Really not intuitive to paste only into cover.
  2. hide the paste options until there is a module on the clipboard

Very nice to have, and maybe only after MVP - to copy and paste either design only or whole module (design and activity).

MendyBerger commented 2 years ago

@corinnewo I honestly don't think that this should be before the MVP, it's currently not broken, and is clearly an advanced feature. Yes we can make it better, but is it worth doing rather then other tasks?

Removing from MVP, but if you disagree add it back in

ChaykeeMor commented 2 years ago

@MendyBerger @corinnewo If we are not doing this for the MVP, we should completely hide "advanced options" from the menu until it works.

corinnewo commented 2 years ago

At the moment you can ONLY paste to the cover. If you paste from another JIG, you have to go to the cover of the target JIG and paste. But if I want to put the new module in the middle of a jig, cannot. There is only a paste in the cover. There should be a paste in every one of the kebab menus, and the paste will replace the content of the chosen activity.

@GaliShapira confirmed this is how to proceed, but we need @ChaykeeMor to finalise text and warning:

  1. For every activity that is already populated, add option of "Paste to replace this activity" to every advanced menu in each activity's kebab menu.
  1. If there is nothing that has been copied, then the "Paste" option is disabled.
  2. On the empty blue 'Drag activity here' item, have the option to "Paste" and "Delete". Paste will replace the empty item, and a new empty will appear below it.

Chaykee - your suggestion to copy design or copy content etc is too complex to do at the moment. Please can you look at the texts above and reword, then Gali will add the design here, ready for Mendy.

corinnewo commented 2 years ago

THanks Gali - just a comment for Chaykee - the from another JIG" is not necessary, as you could paste within the same JIG too. It is just what is on the 'clipboard'. Also, Gali, there is currently a DELETE option on the empty module, so I think we need to keep it and add in the extra paste option.

GaliShapira commented 2 years ago

I updated my comments, thanks Corinne

corinnewo commented 2 years ago

@GaliShapira Chaykee is working on the texts for this. She will be in touch with her corrections.

ChaykeeMor commented 2 years ago

Hey @GaliShapira and @corinnewo

This copy/paste process is a universal function we should not complicate. 'Paste' is never used to mean 'Replace' and I don't think we should make it mean that even if we provide a warning. I understand the need to possibly replace a cover but not an activity so I propose we use the terms 'Copy' [to copy] 'Paste' [if user clicks the menu on empty activity or cover] & 'Paste below' [if user clicks the menu on designed activity or cover]. This should be a function available at top [not hidden in advanced].

'Advanced' should ONLY appear on activities that are auto-generators [cards] and say 'Use content in:' and drop down with 'flashcards' 'memory game' 'matching' 'multiple choice' [whatever 3 options they aren't currently on]

corinnewo commented 2 years ago

Thanks @ChaykeeMor. I agree with your comments. It eliminates the need for a warning. @GaliShapira Please update your Zeplin with these texts and instructions, and we can give it to Mendy.

GaliShapira commented 2 years ago

So this is what we have. Many changes on the activities menus:

Zeplin: https://zpl.io/aNx1K8d

Cover dropdown (with or without content): Pls see all the changes: paste, paste below

Screen Shot 2022-08-04 at 14 45 27

Activity dropdown (with or without content): Pls see all the changes: Advanced only for cards games, cards games opened in a new popup, paste, paste below

Screen Shot 2022-08-04 at 16 37 40

Drag here dropdown:

Screen Shot 2022-08-04 at 14 50 08

Publish dropdown:

Screen Shot 2022-08-04 at 14 50 26

Paste is disabled when nothing was copied.

Screen Shot 2022-08-04 at 16 47 45
ChaykeeMor commented 2 years ago

I don't mind how long it is. But 'Copy' and 'Paste' should be above 'Duplicate'. 'Hide' should be right before delete. and the Advanced text is still wrong. Should be 'Use content in:' and drop down with 'flashcards' 'memory game' 'matching' 'multiple choice' [currently still called card quiz]. and Publish should say 'Edit' not 'Edit setting'

corinnewo commented 2 years ago

I agree with Chaykee regarding order of items. Please also add that if there is nothing copied yet (clipboard empty) then the Paste is disabled. Also, please make sure that it is clear that the Advanced is ONLY for card games. At the moment, all the popups have 'Advanced' and if you click it, there is nothing! Rather not have it at all if it is empty!

GaliShapira commented 2 years ago

Thanks for the feedback Chaykee, I updated my comment. Hope it can be doable in one ticket...

GaliShapira commented 2 years ago

Thanks Corinne, I add it as well.

corinnewo commented 2 years ago

@GaliShapira Please update the Zeplin for the Publish menu - Edit and not Edit setting

GaliShapira commented 2 years ago

Its updated. Can you check again?

corinnewo commented 2 years ago

OK - Thanks! Ready for @MendyBerger !

corinnewo commented 1 year ago

Closed in favor of #3252