johnnynotsolucky
commented
2 years ago Removed the quick fix label - this requires some work to update the data of the copied game.
Open corinnewo opened 2 years ago
johnnynotsolucky
commented
2 years ago Removed the quick fix label - this requires some work to update the data of the copied game.
corinnewo
commented
2 years ago It already works that you can save as a different module - that is all working. All the data should already be there. This ticket is to open the new module on the settings tab rather than the preview tab. WOuld that not be a quick fix?
On Mon, Feb 21, 2022 at 7:30 AM Tyrone Tudehope @.***> wrote:
Removed the quick fix label - this requires some work to update the data of the copied game.
— Reply to this email directly, view it on GitHub https://github.com/ji-devs/ji-cloud/issues/2396#issuecomment-1046489961, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD4JEOLQU4NZ53LTXLKXEJTU4HEYLANCNFSM5OKZBW7A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
--
•••
Corinne Ossendryver CPO
Jewish Interactive
mobile +27 (0)79 886 5326 web www.jewishinteractive.org
skype jewish.interactive fax 086 273 0351 (SA only) twitter @jewishinteract facebook www.facebook.com/JewishInteractive
johnnynotsolucky
commented
2 years ago @corinnewo the current step that a teacher is auto-navigated to is data stored in the DB - when the game is created from another, the data is cloned. So if that game marked the current step as “Preview”, then the new game would have the same value.
corinnewo
commented
2 years ago It's not a different game, it is in a JIG, creating a different module within the same JIG. So we have to go to the original module and mark the current step as SETTINGS before the info gets cloned? It is actually cloned after the preview step.
On Tue, Feb 22, 2022 at 3:05 PM Tyrone Tudehope @.***> wrote:
@corinnewo https://github.com/corinnewo the current step that a teacher is auto-navigated to is data stored in the DB - when the game is created from another, the data is cloned. So if that game marked the current step as “Preview”, then the new game would have the same value.
— Reply to this email directly, view it on GitHub https://github.com/ji-devs/ji-cloud/issues/2396#issuecomment-1047776489, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD4JEOPK2RBO53EGOHRXWQ3U4OCYNANCNFSM5OKZBW7A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
--
•••
Corinne Ossendryver CPO
Jewish Interactive
mobile +27 (0)79 886 5326 web www.jewishinteractive.org
skype jewish.interactive fax 086 273 0351 (SA only) twitter @jewishinteract facebook www.facebook.com/JewishInteractive
johnnynotsolucky
commented
2 years ago @corinnewo sorry, I meant activity, not game. Yes effectively what you said, but instead of doing it manually, we will mark the current step using code so that when the new module loads, they'll be navigated to the settings tab.
corinnewo
commented
2 years ago That sounds good to me!
On Tue, Feb 22, 2022 at 5:51 PM Tyrone Tudehope @.***> wrote:
@corinnewo https://github.com/corinnewo sorry, I meant activity, not game. Yes effectively what you said, but instead of doing it manually, we will mark the current step using code so that when the new module loads, they'll be navigated to the settings tab.
— Reply to this email directly, view it on GitHub https://github.com/ji-devs/ji-cloud/issues/2396#issuecomment-1047936580, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD4JEOPBX5XPRDHA6I55NYTU4OWI3ANCNFSM5OKZBW7A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
--
•••
Corinne Ossendryver CPO
Jewish Interactive
mobile +27 (0)79 886 5326 web www.jewishinteractive.org
skype jewish.interactive fax 086 273 0351 (SA only) twitter @jewishinteract facebook www.facebook.com/JewishInteractive
In the card games, when you save as another type of card game, please open up at the settings stage in the wizard (Step 3), rather than at the preview (Step 4), so that teachers can see the various options available to them.