ji-just-ji / pe

0 stars 0 forks source link

Input unit can be any value. #2

Open ji-just-ji opened 10 months ago

ji-just-ji commented 10 months ago

I can have my course unit at any value which the user may input wrongly.

image.png

image.png

soc-se-bot commented 9 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

partnercourse add: Mismatch among the UG, hints from software and the feature

According to the hints given in the software, non-negative numeric value should be accepted.

As shown in the picture below, this value is accepted. image.png

However, As shown in the pictures below, this value is rounded up. image.png

image.png


[original: nus-cs2103-AY2324S1/pe-interim#5367] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Problem can only happen in case of sabotage, thus not a bug. (as per course website guidelines) University units are usually whole numbers, max. 2d.p.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** If you know the limits to University course units as you responded to the original bug report, then you should have introduced a check for what units you can put when adding a course. Especially for local courses.
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:** Missing some usability -> Feature Flaw. ![image.png](https://raw.githubusercontent.com/ji-just-ji/pe/main/files/cd8dca7f-7a9f-4980-8757-f0d4a9693585.png)