search

jiachen247 / pe

0 stars 0 forks source link

Varargs in find command are misleading #11

Open jiachen247 opened 4 years ago

jiachen247 commented 4 years ago

The ... behind the optional parameter is misleading. If you refer to address book UG, find KEYWORD [MORE KEYWORD] will suffice.

Screenshot 2020-04-17 at 3.18.42 PM.png

nus-pe-bot commented 4 years ago

Team's Response

We disagree with formatting find KEYWORD [MORE KEYWORD] in AB3 as this would mean that we can only accept 1 more keyword. The ... as explained in part 4. of UG states that arguments suffixed with ... can be used multiple times, including 0 times, which is precisely our intended meaning. We will reduce the severity to very low because it's purely cosmetic.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]