Not working in Firefox 21

jiahuang / d3-timeline

Simple JS timeline plugin for d3

1.04k stars 281 forks source link

Not working in Firefox 21 #13

Closed jiahuang closed 10 years ago

jiahuang commented 11 years ago

uncaught exception: width of the timeline is not set

slattery commented 10 years ago

@rrotaru and I ran into this, and we juggled the tests to accommodate the attr('width', nnn) call https://gist.github.com/slattery/10483969 If this is OK we can fix it up and submit a PR.

jiahuang commented 10 years ago

Thanks for fixing the issue. Please go ahead and submit a PR.

ghost commented 10 years ago

the @slattery and @rrotaru fix for FF works great, not sure if they ever submitted a PR

jiahuang commented 10 years ago

closed via https://github.com/jiahuang/d3-timeline/pull/25