search

jiahuang / d3-timeline

Simple JS timeline plugin for d3
1.04k stars 281 forks source link

Fixes the labelFunction() bug to show the label on the Y axis. #62

Closed tomhle closed 9 years ago

tomhle commented 9 years ago

getLabel checked for a null labelFunction, always executing the no-op default.

Now it doesn't.

jiahuang commented 9 years ago

Thanks for all the fixes!

inodb commented 9 years ago

This looks cool!

We should come up with a better way to test regression before merging though because it breaks the mapping by color example:

Old: screen shot 2015-06-30 at 6 51 24 pm After PR: screen shot 2015-06-30 at 6 51 38 pm

The labels on the complex timeline also seem to be incorrect:

screen shot 2015-06-30 at 6 55 46 pm