search

jiahuang / d3-timeline

Simple JS timeline plugin for d3
1.04k stars 280 forks source link

Text alignment #69

Closed marcbowes closed 9 years ago

marcbowes commented 9 years ago

In the readme: https://github.com/jiahuang/d3-timeline/blob/master/examples/timeline4.png

"person" is vertically aligned with the bar. This is pleasing! :+1:

However, when I look at the example (https://github.com/jiahuang/d3-timeline/blob/master/examples/example.html) it is not well aligned at all. "person" is shifted down several pixels. (See screenshot.)

I literally downloaded the example, so I'm not sure what I could have done wrong:

mozilla_firefox
inodb commented 9 years ago

Things seem to be alright in this commit:

http://rawgit.com/jiahuang/d3-timeline/081e83b4926708b9e1822aa3d3e5e5541a5abc84/examples/example.html

Looks like the latest released version also has an issue where the labels disappear:

http://rawgit.com/jiahuang/d3-timeline/1b21c455faee5cf9f786956eefbf09530c63be1d/examples/example.html

inodb commented 9 years ago

This looks like a duplicate of #68 btw

marcbowes commented 9 years ago

Oops, thanks.