jiahuang / d3-timeline

Simple JS timeline plugin for d3
1.04k stars 280 forks source link

spelling of .rowSeperators(color) #77

Closed ryanfox closed 8 years ago

ryanfox commented 8 years ago

The word "sepArators" is spelled with an a, not an e as in "sepErators". If changing the name of the function isn't desirable due to breaking backwards compatibility, perhaps adding a wrapper function with the correct spelling could be useful?

danuep commented 8 years ago

There's an outstanding pull request #75 from @danhunsaker that corrects this spelling, though it doesn't include the wrapper for compatibility that you suggested.

danhunsaker commented 8 years ago

Said wrapper would probably be a good idea...

inodb commented 8 years ago

Thanks for your suggestions. Added @danhunsaker's changes now w/o wrapper. I think it's fine to break compatibility at this stage of development.