jiahui0309 / pe

0 stars 0 forks source link

Incorrect expectation of corrupted files #17

Open jiahui0309 opened 5 months ago

jiahui0309 commented 5 months ago

For DG: saving data, the expected should be that the app launches with an empty folder, based on your UG. This will be misleading for readers

Screenshot 2024-04-19 at 5.12.05 PM.png

Screenshot 2024-04-19 at 5.10.51 PM.png

nus-pe-script commented 5 months ago

Team's Response

Thanks for the bug report, but the information provided about how the data file is empty at the start is correct, as the data file is initialised as empty at the start of the next run, and then populated with sample data, which would make the documentation correct.

We understand that this may be confusing for the user, and it is a good idea to give the user more information about how the newly created empty file is then populated with sample contacts in a future iteration, so while it may be out of scope for v.1.4, you do make a valid point.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Hi! When I tried to add invalid text into your json file, it did discard all the data and start with an empty data file the next run, as shown in the first image in the UG.

However, in the DG, I saw that section for simulating a corrupted file, I was actually expected to have a set of sample contacts, which made me confused.

Furthermore, your response also said that it is correct to say that it will be populated with sample data, which contradicts the actual behavior of having a corrupted JSON file. The actual behaviour was that FinCliq will discard all data and start with an empty data file the next run.

Thank you! :)