jiahui0309 / pe

0 stars 0 forks source link

Duplicate detection for Add #2

Open jiahui0309 opened 4 months ago

jiahui0309 commented 4 months ago

Steps:

  1. run add n/James Ho p/22224444 e/jamesho@example.com a/123, Clementi Rd, 1234665 t/friend t/colleague
  2. run add n/James Ho p/22224444 e/jamesho@example.com a/123, Clementi Rd, 1234665 t/friend t/colleague

Screenshot 2024-04-19 at 4.12.38 PM.png

expected: to throw an error to users indicating that the names are the same. this is different from your planned enhancements 3 as ur app allows people with sematically same name to be added

actual: successful addition

Screenshot 2024-04-19 at 5.03.41 PM.png

Your UG mentioned that it will be processed as a single space, but it is not followed. but I will put low instead of med

nus-se-bot commented 4 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Allow adding duplicated email address for add command

As shown in the screenshot below, the program allow user to insert duplicated email address for different person (Client index 12 and 13).

In real-world scenario, email address should be unique, and no more than one person can have the same email address. In this case, it will cause the user to send information to the wrong person as the email address entered are duplicated and caused inconvenience to the user to double check the accuracy of insertion.

Screenshot 2024-04-19 at 4.38.25 PM.png

It would be great for the team to detect duplication in the insertion of email address such that duplicated email address is not allowed/ warning message can be shown.


[original: nus-cs2103-AY2324S2/pe-interim#390] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

In our documentation, we stated the following: Screenshot 2024-04-20 at 1.16.35 PM.png

We downgraded the severity to low, as this scenario only happens rarely (people do not edit their client's emails to be duplicates of other client's emails often, if not at all).

Screenshot 2024-04-20 at 1.19.50 PM.png

This case also qualifies for the highlighted case, as duplicate detection based on email is currently not a feature, although it has been identified as a planned enhancement, and trying to use the missing feature does not cause the software to crash. Screenshot 2024-04-20 at 1.21.59 PM.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Hi! I understand that your team may have classified my bug report to be a duplicate as Allow adding duplicated email address for add command, since they are similar. However, I took the time to read through the planned enhancements and did not raise the issue of duplicate emails. My report came from the fact that the documentation said that name will be processed as a single space, but it is not followed. Furthermore, the issue of duplicate emails can be solved using your planned enhancements, but not the extra spaces between names.

Also, I am not very sure the reason for duplicating these bugs, since this can be fixed independently from the original bug

Screenshot 2024-04-23 at 12.17.38 PM.png

Thank you :)


## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** HI! I felt that it does not quality as `NotInScope` as the UG explicitly says that it supports the feature, but did not work in reality. This is unlike the criteria of NotInScope bugs. Furthermore, your rationale for placing it in NotInScope seems to argue against the original bug instead of mine. I felt that the issue of duplicate emails can be solved using your planned enhancements, but not the extra spaces between names. There was no mention that it is less important in v1.4/will be supported next time. ![Screenshot 2024-04-23 at 11.58.11 AM.png](https://raw.githubusercontent.com/jiahui0309/pe/main/files/9e062fe9-c37a-4dff-a188-03ac55d66d88.png) Thank you :)
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]