search

jiahui0309 / pe

0 stars 0 forks source link

Incorrect error for invalid date #6

Open jiahui0309 opened 7 months ago

jiahui0309 commented 7 months ago
  1. run addMeeting clientIndex/1 dt/29-02-2025 00:00 d/Sign lifeplan

expected: throw an error for invalid date

actual: added successfully as 28th feb

Screenshot 2024-04-19 at 4.25.46 PM.png

nus-se-bot commented 6 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Addmeeting accepts invalid dates and rounds to closes day

image.png

When scheduling a meeting using add meeting, if my datetime is 29th February on a non-leap year e.g. 29/2/2025, the date is rounded to 28/2/2025 and the command is accepted as such instead of throwing an invalid date error message.

Steps to reproduce

  1. Schedule a meeting using addmeeting where all other parameters are valid but the datetime is the 29th of February on a non leap year e.g. addMeeting clientIndex/1 dt/29-02-2025 13:00 d/Sign life plan

Expected: The command should not be accepted Actual: The command is executed successfully and a meeting is scheduled for 28-02-2025 13:00

If this behaviour is intended, it is not specified in the UG or DG from what I can find

Low as it is not a cosmetic issue, but rarely happens and does not impact the user experience much when it happens (you can just delete the unintended meeting right after)

[original: nus-cs2103-AY2324S2/pe-interim#5288] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

image.png

This is Java's implementation for LocalDate and we agree with their design consideration, as the user is already unsure of the date and Java helps them change it to the latest valid date.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]