Open jiakai-17 opened 9 months ago
This issue is a duplicate of #3839 where it states that there is a failure to flag out typos in emails (emails without .com). Therefore, the resolution of this issue will be handled through #3839 where resolution of said issue will also resolve this one.
This is also not a functionality bug as chosen by the tester, as the validity check adheres to our UG.
[The team marked this bug as a duplicate of the following bug]
Fail to flag out typos in emails
Emails does not end with a '.com'
[original: nus-cs2103-AY2324S1/pe-interim#3005] [original labels: type.FeatureFlaw severity.VeryLow]
[This is the team's response to the above 'original' bug]
According to Google, not every email has to end with a ".com", it just has to end with a valid domain. Furthermore, the domain may be an IP address literal, surrounded by square brackets [], such as jsmith@[192.168.2.1] or jsmith@[IPv6:2001:db8::1], although this is rarely seen except in email spam. Therefore, there are many examples of a domain of an email without a ".com" and it may be incorrect to generalize a valid email as one with a ".com".
Other sources on user@abc being valid email inputs: HTML Standard.
Rejecting user@abc inputs is overzealous, as they are valid emails, although rare. We deliberately adopted a more relaxed validation check for email, with the validation check fully documented in the UG.
Therefore, we decided to reject this bug report as it is theoretically incorrect, as explained above.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
Reason for disagreement: [replace this with your explanation]
app: Able to add students with invalid email
Affected Component(s)
[x] Application [ ] User Guide [ ] Developer Guide
Description
The email validity check is faulty. I can add a student with email like
abc@gmail
, which is obviously not a valid email address.Steps to reproduce
Command(s) entered:
Expected behavior
Invalid email is caught, student not added
Actual behavior
student is added
Screenshots, if any
Additional context / Potentially problematic behavior / Improvements
[x] I have checked that this has not been addressed in the Planned Enhancements of the Developer Guide.
Reason for choosing severity level: