jiakai-17 / pe

0 stars 0 forks source link

app: deleting course deletes all students in course #9

Open jiakai-17 opened 9 months ago

jiakai-17 commented 9 months ago

image.png

When a course is deleted, all students in the course is deleted also. There should be a warning to the user that the students will be deleted along.

UG does not state that students will be deleted when a course is deleted.

If a TA accidentally deletes a course, there is also no way to retrieve the student records.

Steps to reproduce

  1. delete any course with students in it

Command(s) entered:

delete course course/cs2030s

Expected behaviour: a warning?

soc-pe-bot commented 9 months ago

Team's Response

Firstly, we feel that this issue cannot be categorized as a functionality bug as logically speaking, by deleting the course, it would only make sense that the students in it are deleted. As an analogy, when we delete folders in our file explorer, it is logical to expect that the files within the folder are deleted. The same concept can be applied for this feature.

Thus, this behaviour is not only intended, but we believe is the logically correct one. It would also be one that users would expect, as it is the only logical outcome (since students are added in the course, when the course is deleted, the students will naturally be deleted). Hence, we do not think that this is a functionality bug.

However, that being said, there can be actions done to ensure that the user is further made aware of the risks in using this command, which includes documentation of the effects of this feature and adding a Caution section in the UG.

Thus, we decided to recategorize this as a documentation bug on our end. We also lowered the severity to a "low" due to the aforementioned reason above (users would expect this and would rarely face problems or be confused over this).

Items for the Tester to Verify

:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]