search

jiakuan / gwt-gradle-plugin

Gradle plugin to support GWT related tasks.
https://gwt-gradle.docstr.org
Other
63 stars 34 forks source link

#28: "Make jvmArgs accessible (Lombok in a linked module)"" #30

Closed jaromor closed 4 years ago

jaromor commented 4 years ago

At this moment I am only pushing the changes in the plugin Java code. The modified/working version of war-using-library with Lombok can be seen in my repo. I hesitate to push that to jiakuan/gwt-gradle-plugin, the reason being I am pretty sure my gradle configuration, while working for me, is NOT the cleanest and/or most efficient approach.

jaromor commented 4 years ago

@jiakuan I have just found out I can't make it work with Gradle above version 4. It seems like Gradle 5 is ignoring my compileGwt/draftCompileGwt configuration. Here is the "problematic" build.gradle file. I am probably reading the situation incorrectly, still investigating. Any thoughts?

jiakuan commented 4 years ago

@jaromor Thanks for your progress made so far. I will try to find some time next week to have a look at this one.

jaromor commented 4 years ago

So the compileGwt/draftCompileGwt configurations actually do get evaluated, I just can't see the javaagent jvmArg anywhere in the Gradle log output.

VIKMSTR commented 4 years ago

What's the status on this, guys? I second to the need of open jvmArgs (also wanna use Lombok). Is it ready to be merged or can I somehow support you with that?

jiakuan commented 4 years ago

I'm not using lombok with GWT at the moment, but just had a quick look.

As starting point, you could experiment with your jvmArgs by adding a line below this: https://github.com/jiakuan/gwt-gradle-plugin/blob/c9e948c3b4e352a31c3aaa4d6205a13ad5d099de/gwt-gradle-plugin/src/main/java/org/wisepersist/gradle/plugins/gwt/AbstractGwtTask.java#L47

If it works, we will then think about code structure to make jvmArgs accessible, which should be similar to existing args.

jiakuan commented 4 years ago

An extraJvmArgs property has been added in #34