jiakuan / gwt-gradle-plugin

Gradle plugin to support GWT related tasks.
https://gwt-gradle.docstr.org
Other
63 stars 34 forks source link

Gradle 6+: use runtimeOnly configuration instead of runtimeElements for declaring dependencies #31

Closed evpaassen closed 4 years ago

evpaassen commented 4 years ago

Adding dependencies to the runtimeElements configuration is deprecated in Gradle 6. It's only meant for querying the dependencies by consumers. Using the plugin with Gradle 6 shows:

The runtimeElements configuration has been deprecated for dependency declaration. This will fail with an error in Gradle 7.0. Please use the implementation or compileOnly or runtimeOnly configuration instead.

I think the dependency should be added to the runtimeOnly configuration instead. but please correct me if I'm wrong.

jiakuan commented 4 years ago

Thanks for your pull request. I will test and release a new version soon.

evpaassen commented 4 years ago

You're welcome.

In the mean time, I've found some other deprecations as well. About missing input and output annotations.

Property 'logLevel' is not annotated with an input or output annotation. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0. Documentation

Property 'maxHeapSize' is not annotated with an input or output annotation. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0. Documentation

Property 'methodNameDisplayMode' is not annotated with an input or output annotation. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0. Documentation

Property 'minHeapSize' is not annotated with an input or output annotation. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0. Documentation

etc.

That'd might be worth fixing too, before releasing a new version. If I can find some time, I might give it a try. But right now I'm not sure how to fix it yet.

evpaassen commented 4 years ago

In the mean time, I've found some other deprecations as well. About missing input and output annotations.

I've created a separate issue for this: #32.