search

jiakuan / gwt-gradle-plugin

Gradle plugin to support GWT related tasks.
https://gwt-gradle.docstr.org
Other
66 stars 34 forks source link

Fix outputs of the compileGwt task #37

Closed evpaassen closed 4 years ago

evpaassen commented 4 years ago

This PR aims to fix #36.

jiakuan commented 4 years ago

Thanks for the pull request. Will check and merge in a couple of days.

On Fri, 9 Oct 2020 at 7:45 pm, Erik van Paassen notifications@github.com wrote:

This PR aims to fix #36 https://github.com/jiakuan/gwt-gradle-plugin/issues/36.

  • The work and cache directories have been marked as internal, so they don't end up in the task outputs.

  • The extra and gen have been made optional and the defaults have been removed. This way, these directories and their contents are only created when explicitly configured.

You can view, comment on, or merge this pull request online at:

https://github.com/jiakuan/gwt-gradle-plugin/pull/37

Commit Summary

  • Do not mark cache and work directories as output.

  • Don't set 'extra' and 'gen' dirs by default.

File Changes

-

M

src/main/java/org/wisepersist/gradle/plugins/gwt/AbstractGwtTask.java https://github.com/jiakuan/gwt-gradle-plugin/pull/37/files#diff-b7e83fdad3a5f0dab270539140c2d7c7

(7)

-

M

src/main/java/org/wisepersist/gradle/plugins/gwt/GwtBasePlugin.java https://github.com/jiakuan/gwt-gradle-plugin/pull/37/files#diff-1a97611dcfdbf95d06e90f2d10934ef5

(4)

-

M

src/main/java/org/wisepersist/gradle/plugins/gwt/GwtSuperDev.java https://github.com/jiakuan/gwt-gradle-plugin/pull/37/files#diff-7d8f61046169f2613061c2f4bf0591d3

(4)

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jiakuan/gwt-gradle-plugin/pull/37, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAECF5FYV4B5RO2SIXJASBDSJ3ZV3ANCNFSM4SJ7D56Q .

evpaassen commented 4 years ago

Thanks for merging! :)

May I ask, will there be a new release with this fix anywhere in the near future?

jiakuan commented 4 years ago

Almost ready to create a new release - just need to test another issue. Will be done in a couple of days.

jiakuan commented 4 years ago

Released 1.1.10.

plugins {
  id "org.wisepersist.gwt" version "1.1.10"
}
evpaassen commented 4 years ago

That's great! Thanks again.