search

jiakuan / gwt-gradle-plugin

Gradle plugin to support GWT related tasks.
https://gwt-gradle.docstr.org
Other
63 stars 34 forks source link

#47 Not setting gwtVersion will not cause a warning #48

Closed SoltauFintel closed 3 years ago

SoltauFintel commented 3 years ago

but setting an illegal value for gwtVersion will cause an exception (instead of warning) GwtVersion.parseOrNull() removed. New testcase.

SoltauFintel commented 3 years ago

Not tested within Gradle build. I'm going to test it after release.

SoltauFintel commented 3 years ago

The build fails?? see https://app.travis-ci.com/github/SoltauFintel/gwt-gradle-plugin/builds/233196351

Maybe version must be changed in /gwt-gradle-plugin/examples/build.gradle ??

jiakuan commented 3 years ago

The build fails?? see https://app.travis-ci.com/github/SoltauFintel/gwt-gradle-plugin/builds/233196351

Maybe version must be changed in /gwt-gradle-plugin/examples/build.gradle ??

Have fixed in master

SoltauFintel commented 3 years ago

Not tested within Gradle build. I'm going to test it after release.

@jiakuan I've tested 1.1.13 and it looks good.

jiakuan commented 3 years ago

Cool. Thanks for confirming the test result.

On Wed, 21 Jul 2021 at 12:25 am, SoltauFintel @.***> wrote:

Not tested within Gradle build. I'm going to test it after release.

@jiakuan https://github.com/jiakuan I've tested 1.1.13 and it looks good.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/jiakuan/gwt-gradle-plugin/pull/48#issuecomment-883526974, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAECF5HWKRHVSL3ED2DFLC3TYWPPFANCNFSM5AVP4SSQ .