search

jiakuan / gwt-uploader

An API to enable sophisticated file upload capabilities within a GWT application.
http://gwt-uploader.appspot.com/
Apache License 2.0
11 stars 6 forks source link

Removed SWF / Flash library since it is long dead #10

Closed Lonzak closed 1 year ago

Lonzak commented 1 year ago

This is a first version where I did remove the swf part of the uploader. It needs code review since my knowledge is limited in this area.

jiakuan commented 1 year ago

Thanks for the pull request. I will find a chance to review over the weekend.

jiakuan commented 1 year ago

Have you got a chance to test the functionality after Flash related stuff have been removed?

Lonzak commented 1 year ago

I did update to gwt 2.10.0 however there are certain problems: The gradle plugin (de.richsource.gradle.plugins:gwt-gradle-plugin:0.6) isn't maintained anymore and it is not compatible with GWT 2.10.0. It looks in the wrong package (com.google.gwt instead of org.gwtproject)... But as I saw you also maintain a fork of a gwt plugin (https://github.com/jiakuan/gwt-gradle-plugin) ? Maybe you can change to this plugin?

Or we do ignore the warnings for now.

I did test the plugin with our application and for us it works...

jiakuan commented 1 year ago

I did update to gwt 2.10.0 however there are certain problems:

The gradle plugin (de.richsource.gradle.plugins:gwt-gradle-plugin:0.6) isn't maintained anymore and it is not compatible with GWT 2.10.0. It looks in the wrong package (com.google.gwt instead of org.gwtproject)... But as I saw you also maintain a fork of a gwt plugin (https://github.com/jiakuan/gwt-gradle-plugin) ? Maybe you can change to this plugin?

Or we do ignore the warnings for now.

I did test the plugin with our application and for us it works...

Great, thanks!

I agree with your previous comment. We could leave the GWT upgrade and plug-in upgrade to a separate PR. I will check and merge this one first.

Lonzak commented 1 year ago

ah sorry - I did also commit the gwt. 2.10.0 update to this PR ... Do you plan to create a release out of it? That would be nice...

jiakuan commented 1 year ago

No problem.

I've merged and I will need to fix some issues and cleanup the project structure a little bit.

After that, I will create a new release.