nus-se-bot
commented
1 year ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Possible duplicate offer issue
(Same video as before. Sorry!)
Seems like offers from the same person and for the same listing can be with different prices? This seems a little unrealistic for real estate agents since old offers shouldn't stand anymore. I think it might make more sense if this is disallowed.
[original: nus-cs2103-AY2223S1/pe-interim#309] [original labels: type.FeatureFlaw severity.VeryLow]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
There might be a situation where 2 different people with the same names are both interested in the same listing, hence we cannot say that adding 2 offers with same name and for the same listing can come from the same person. If such a situation as you mentioned arises, then it would make sense for the user to use the edit offer feature rather than adding a new offer.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: This is a bug since the program itself should check for people with duplicate offers.
In your response, your team mentioned that the user itself should MANUALLY check for a duplicate offer and then choose to edit offer instead of add a new offer. However, in the case where a property has ~100 biddings and given that your application does not have a find/filter feature for offers, this is very hard and time consuming for the user.
:question: Issue type
Team chose [type.FeatureFlaw]
Originally [type.FunctionalityBug]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
:question: Issue severity
Team chose [severity.VeryLow]
Originally [severity.Low]
- [x] I disagree
Reason for disagreement: This is not a cosmetic issue. Better alternatives could be
- Allow the command to overwrite the original offer but display a warning feedback message saying that the original is overwritten
- Block the command and display an error feedback message
addO l/30_SERGARDENS_LOR23_0718 n/Bob o/600000addO l/30_SERGARDENS_LOR23_0718 n/Bob o/620000Both commands are allowed even though doing this will clutter the offer box UI as the same person might give multiple offers.
The second command could overwrite the first command. Another alternative would be that to allow both commands but give an error message to the user.