1.4.24 fails to build with -Werror

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Try to compile

What is the expected output? What do you see instead?

Expected compile to succeed.

What version of the product are you using? On what operating system?
1.4.24

Please provide any additional information below.

items.c:1141:28: error: comparison of constant 256 with expression of type 
'uint8_t' (aka 'unsigned char') is always true 
[-Werror,-Wtautological-constant-out-of-range-compare]
    assert(it->slabs_clsid < LARGEST_ID);
           ~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~
/usr/include/assert.h:54:21: note: expanded from macro 'assert'
#define assert(e)       ((e) ? (void)0 : __assert(__func__, __FILE__, \
                          ^
1 error generated.

Full log available of course.

Original issue reported on code.google.com by steve.wi...@gmail.com on 27 Jun 2015 at 6:06

[GoogleCodeExporter]

Here's the full log

Original comment by steve.wi...@gmail.com on 27 Jun 2015 at 6:07

Attachments:

• memcached-1.4.24.log

[GoogleCodeExporter]

weird. wonder why the clang fix didn't get that one... it's the same.

I've fixed this in the 'next' branch, thanks.

Original comment by dorma...@rydia.net on 5 Jul 2015 at 1:12

• Changed state: Fixed