jianyangg / pe

0 stars 0 forks source link

Messy error messages #3

Open jianyangg opened 11 months ago

jianyangg commented 11 months ago

Steps to reproduce:

  1. Key in a wrong command
  2. Key in a correct command

The messages returned are in the next immediate line and not separated clearly (i.e., with a newline). This affects the visibility of the error messages and messages in general as I'm unable to tell right away what the system is telling me about my most recent input.

Currently:

Invalid command format! 
addstaff: Adds a person to the address book. Parameters: n/NAME p/PHONE e/EMAIL a/ADDRESS [t/TAG]...
Example: addstaff n/John Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 t/friends t/owesMoney
New person added: Isaac; Phone: 92345678; Email: isaac@gmail.com; Address: Blk 456, Pasir Ris St 32; Tags: [marketing]

I would prefer if it was:

Error:
Invalid command format! 
addstaff: Adds a person to the address book. Parameters: n/NAME p/PHONE e/EMAIL a/ADDRESS [t/TAG]...
Example: addstaff n/John Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 t/friends t/owesMoney

Success:
New person added: Isaac; Phone: 92345678; Email: isaac@gmail.com; Address: Blk 456, Pasir Ris St 32; Tags: [marketing]

Screenshot 2023-11-17 at 4.17.44 PM.png

This FeatureFlaw might warrant a higher severity since it's quite a common issue to have error messages / for system to give feedback to users.

nus-pe-bot commented 11 months ago

Team's Response

In the DG's planned enhancement section, we have already added "Add separation between command results in results box for easier distinguishing", so we will reject this

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]